introduce rector to perform better laravel upgrades#657
Open
comes wants to merge 1 commit intoOpenLitterMap:masterfrom
Open
introduce rector to perform better laravel upgrades#657comes wants to merge 1 commit intoOpenLitterMap:masterfrom
comes wants to merge 1 commit intoOpenLitterMap:masterfrom
Conversation
Member
|
Thanks @comes its been on my todo list for a while, I'm happy with 90% of this but it breaks a little bit of my coding style for better readability and don't have the time to dig into new rules at the moment. I'm focused on a few other things at the moment, ill come back to this when I can Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest using rector for upgrades to support this project and modernize the code base.
This PR provides a rector dependency and a very basic configuration. It also does some minor upgrades to the code base that are part of the upgrade guidelines when upgrading to laravel 11.
To learn more about rector, see rector.org
To run rector, you need to run
./vendor/bin/rector.This PR is one of many to improve the OpenLitterMap code base and modernize it for a brighter future regarding readability and scalability.
All the best @xlcrr
Jeremias